Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change section fade behavior and related things a bit #1146

Closed
9 tasks done
helgoboss opened this issue Aug 29, 2024 Discussed in #1142 · 0 comments
Closed
9 tasks done

Change section fade behavior and related things a bit #1146

helgoboss opened this issue Aug 29, 2024 Discussed in #1142 · 0 comments
Labels
enhancement New feature or request playtime Related to Playtime
Milestone

Comments

@helgoboss
Copy link
Owner

helgoboss commented Aug 29, 2024

Great!

Q&A discussions are supposed to be left open, so that other people can look up the answers as well. It would be cool if you could mark something as an answer though. Thanks!

I think I came up with a good way to deal with this in a better way. At least it makes sense to me at the moment ;)

  • NEW: Rename "Static section" to Source cut (because that's its function ... to cut the original audio file in a non-destructive way, cropping away material from the start and end, that cropped-away material will not be visible in Playtime's waveform viewer)
  • NEW: Rename "Dynamic section" to Section (a section that can be played with as part of a live performance)
  • Always auto-fade sections (this is already the case). Rationale: Sections can change in unforeseen ways ... the section start and end can be anywhere. So it always makes sense to auto-fade, in order to avoid click noises.
  • Apply "Source fades" (if enabled) at start and end of source file (already the case) or the source cut respectively (NEW ... before that, the source cut fades would always be applied).
  • When recording audio within Playtime, enable source fades and set the source cut accordingly (already the case).
  • NEW: When importing audio from a file, disable "Source fades" and don't change the source cut.
  • When importing audio from an item, set the source cut according to the take offset and item length (already done).
    • If item has a fade (> 0ms) at its start, enable "Source fades" (it will not be exactly the same fade, but enough to avoid clicks).
    • NEW: If item doesn't have a fade at its tart, disable "Source fades" (this in particular would have prevented your issue).

No need to comment on that, unless you see something weird (this is more like a todo list for myself).

@helgoboss helgoboss added enhancement New feature or request playtime Related to Playtime labels Aug 29, 2024
@helgoboss helgoboss added this to the 2.16.4 milestone Aug 29, 2024
@helgoboss helgoboss moved this from Todo to In Progress in Helgobox Development Sep 4, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Helgobox Development Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request playtime Related to Playtime
Projects
Status: Done
Development

No branches or pull requests

1 participant