Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playtime: Recording can lead to error "ring buffer too small for writing block" in some cases #1105

Closed
helgoboss opened this issue Aug 15, 2024 · 3 comments
Closed

Playtime: Recording can lead to error "ring buffer too small for writing block" in some cases #1105

helgoboss opened this issue Aug 15, 2024 · 3 comments
Labels
bug Something isn't working need more info Further information is requested playtime Related to Playtime
Milestone
2.16.2

Comments

@helgoboss
Copy link
Owner

See email from Winfried
@helgoboss helgoboss added bug Something isn't working playtime Related to Playtime labels Aug 15, 2024
@helgoboss
Copy link
Owner Author

--- cut ---
REAPER version: 7.18/x64
Module name: Helgobox
Module version: v2.16.0/x86_64 rev f0cb58 (2024-07-07 13:14:35 UTC)
Module base address: 0x7ffce54b0000
Module size: 0x2755000
Message: called Result::unwrap() on an Err value: "ring buffer too small for writing block"
0: 0x7ffce6b1298b - VSTPluginMain
1: 0x7ffce6b106a2 - VSTPluginMain
2: 0x7ffce6a8741b - VSTPluginMain
3: 0x7ffce6d1bbc7 - cpp_to_rust_ProjectStateContext_SetTempFlag
4: 0x7ffce6d1ba57 - cpp_to_rust_ProjectStateContext_SetTempFlag
5: 0x7ffce6d19e3f - cpp_to_rust_ProjectStateContext_SetTempFlag
6: 0x7ffce6d1b708 - cpp_to_rust_ProjectStateContext_SetTempFlag

7: 0x7ffce700c5e4 - cpp_to_rust_ProjectStateContext_SetTempFlag
8: 0x7ffce700ca40 - cpp_to_rust_ProjectStateContext_SetTempFlag
9: 0x7ffce68d0299 - VSTPluginMain
10: 0x7ffce68cfcf4 - VSTPluginMain
11: 0x7ffce69acf72 - VSTPluginMain
12: 0x7ffce69a4b76 - VSTPluginMain
13: 0x7ffce68cede1 - VSTPluginMain
14: 0x7ffce5f3ed5b - invoke_host
15: 0x7ffce5f421ca - invoke_host
16: 0x7ffce5f6cbad - invoke_host
17: 0x7ffce6062820 - DllMain
18: 0x140624655 -
19: 0x140053232 -
20: 0x7ffd296e24a4 -
21: 0x7ffd296e1bb0 -
22: 0x7ffd30d37374 - BaseThreadInitThunk
23: 0x7ffd317dcc91 - RtlUserThreadStart
--- cut ---

@helgoboss helgoboss added the need more info Further information is requested label Aug 20, 2024
@helgoboss
Copy link
Owner Author

Couldn't reproduce, even with Winfried's INI files. Asked him to try with a fresh portable installation.

@helgoboss
Copy link
Owner Author

Problem was combination of very high sample rate with very low buffer size. Need to improve handling of those during recording.

@helgoboss helgoboss moved this to In Progress in Helgobox Development Aug 21, 2024
helgoboss added a commit that referenced this issue Aug 21, 2024
@helgoboss
#1105 Multiple changes
e45e025 
- Make sure to write all recorded material to file (this was not guaranteed before and indeed caused files to be incomplete when using high sample rates and low buffer sizes)
- Make recording worker also use high thread priority
- Make ring buffer size depend on sample rate and make it slightly larger
@helgoboss helgoboss added this to the 2.16.2 milestone Aug 21, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Helgobox Development Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working need more info Further information is requested playtime Related to Playtime
Projects
Helgobox Development
Archived in project
Milestone
2.16.2
Development

No branches or pull requests
1 participant
@helgoboss