#160 Fix build warnings

main/Cargo.toml

@@ -16,14 +16,14 @@ generate = []
 prometheus = ["serde_prometheus"]
 
 [dependencies]
-# reaper-rx = { git = "https://github.com/helgoboss/reaper-rs.git", branch = "master" }
-# reaper-high = { git = "https://github.com/helgoboss/reaper-rs.git", branch = "master", features = ["serde"] }
-# reaper-medium = { git = "https://github.com/helgoboss/reaper-rs.git", branch = "master", features = ["serde"] }
-# reaper-low = { git = "https://github.com/helgoboss/reaper-rs.git", branch = "master" }
-reaper-rx = { path = "../../reaper-rs/main/rx" }
-reaper-high = { path = "../../reaper-rs/main/high", features = ["serde"] }
-reaper-medium= { path = "../../reaper-rs/main/medium", features = ["serde"] }
-reaper-low = { path = "../../reaper-rs/main/low" }
+ reaper-rx = { git = "https://github.com/helgoboss/reaper-rs.git", branch = "master" }
+ reaper-high = { git = "https://github.com/helgoboss/reaper-rs.git", branch = "master", features = ["serde"] }
+ reaper-medium = { git = "https://github.com/helgoboss/reaper-rs.git", branch = "master", features = ["serde"] }
+ reaper-low = { git = "https://github.com/helgoboss/reaper-rs.git", branch = "master" }
+#reaper-rx = { path = "../../reaper-rs/main/rx" }
+#reaper-high = { path = "../../reaper-rs/main/high", features = ["serde"] }
+#reaper-medium= { path = "../../reaper-rs/main/medium", features = ["serde"] }
+#reaper-low = { path = "../../reaper-rs/main/low" }
 swell-ui = { path = "../swell-ui" }
 rx-util = { path = "../rx-util" }
 helgoboss-midi = { version = "0.2", features = ["serde", "serde_repr"] }

main/src/application/mapping_model.rs

@@ -10,8 +10,8 @@ use crate::application::{
 use crate::core::{prop, Prop};
 use crate::domain::{
     ActivationCondition, CompoundMappingTarget, ExtendedProcessorContext, ExtendedSourceCharacter,
-    MainMapping, MappingCompartment, MappingId, ProcessorContext, ProcessorMappingOptions,
-    RealearnTarget, ReaperTarget, TargetCharacter,
+    MainMapping, MappingCompartment, MappingId, ProcessorMappingOptions, RealearnTarget,
+    ReaperTarget, TargetCharacter,
 };
 
 use std::cell::RefCell;

main/src/application/preset.rs

@@ -1,5 +1,5 @@
 use crate::application::{GroupModel, MappingModel, SharedGroup, SharedMapping, TargetCategory};
-use crate::domain::{ExtendedProcessorContext, ProcessorContext, VirtualFx, VirtualTrack};
+use crate::domain::{ExtendedProcessorContext, VirtualFx, VirtualTrack};
 use std::fmt;
 use std::fmt::Debug;
 

main/src/application/session.rs

@@ -10,7 +10,6 @@ use crate::domain::{
     NormalRealTimeTask, OscDeviceId, ParameterArray, ProcessorContext, RealSource, ReaperTarget,
     TargetValueChangedEvent, VirtualSource, PLUGIN_PARAMETER_COUNT, ZEROED_PLUGIN_PARAMETERS,
 };
-use enum_iterator::IntoEnumIterator;
 use enum_map::EnumMap;
 
 use reaper_high::Reaper;

main/src/application/target_model.rs

@@ -20,7 +20,6 @@ use crate::domain::{
 use serde_repr::*;
 use std::borrow::Cow;
 
-use fasteval::Compiler;
 use reaper_medium::BookmarkId;
 use std::fmt;
 use std::fmt::{Display, Formatter};

main/src/domain/main_processor.rs

@@ -6,7 +6,6 @@ use crate::domain::{
     RealearnMonitoringFxParameterValueChangedEvent, ReaperTarget, SourceValue,
     TargetValueChangedEvent, VirtualSourceValue,
 };
-use enum_iterator::IntoEnumIterator;
 use enum_map::EnumMap;
 use helgoboss_learn::{ControlValue, MidiSource, OscSource, UnitValue};
 

main/src/domain/mapping.rs

@@ -1,7 +1,7 @@
 use crate::domain::{
     ActivationChange, ActivationCondition, ControlOptions, ExtendedProcessorContext,
-    MappingActivationEffect, Mode, ParameterArray, ProcessorContext, RealearnTarget, ReaperTarget,
-    TargetCharacter, UnresolvedReaperTarget, VirtualSource, VirtualSourceValue, VirtualTarget,
+    MappingActivationEffect, Mode, ParameterArray, RealearnTarget, ReaperTarget, TargetCharacter,
+    UnresolvedReaperTarget, VirtualSource, VirtualSourceValue, VirtualTarget,
 };
 use derive_more::Display;
 use enum_iterator::IntoEnumIterator;

main/src/domain/real_time_processor.rs

@@ -15,7 +15,6 @@ use slog::debug;
 use std::collections::HashMap;
 
 use crate::core::Global;
-use enum_iterator::IntoEnumIterator;
 use enum_map::{enum_map, EnumMap};
 use std::ptr::null_mut;
 use std::time::Duration;

main/src/domain/unresolved_reaper_target.rs

@@ -1,9 +1,8 @@
 use crate::application::BookmarkAnchorType;
 use crate::core::hash_util;
 use crate::domain::{
-    ActionInvocationType, DomainGlobal, ExtendedProcessorContext, ParameterArray, ProcessorContext,
-    ReaperTarget, SoloBehavior, TouchedParameterType, TrackExclusivity, TransportAction,
-    PLUGIN_PARAMETER_COUNT,
+    ActionInvocationType, DomainGlobal, ExtendedProcessorContext, ParameterArray, ReaperTarget,
+    SoloBehavior, TouchedParameterType, TrackExclusivity, TransportAction, PLUGIN_PARAMETER_COUNT,
 };
 use derive_more::{Display, Error};
 use fasteval::{Compiler, Evaler, Instruction, Slab};
@@ -408,7 +407,7 @@ impl ExpressionEvaluator {
 
     fn evaluate_internal(&self, params: &ParameterArray) -> Result<f64, fasteval::Error> {
         use fasteval::eval_compiled_ref;
-        let mut cb = |name: &str, args: Vec<f64>| -> Option<f64> {
+        let mut cb = |name: &str, _args: Vec<f64>| -> Option<f64> {
             if !name.starts_with('p') {
                 return None;
             }

main/src/infrastructure/data/mapping_model_data.rs

@@ -1,6 +1,6 @@
 use crate::application::{GroupId, MappingModel};
 use crate::core::default_util::is_default;
-use crate::domain::{ExtendedProcessorContext, MappingCompartment, MappingId, ProcessorContext};
+use crate::domain::{ExtendedProcessorContext, MappingCompartment, MappingId};
 use crate::infrastructure::data::{
     ActivationConditionData, EnabledData, MigrationDescriptor, ModeModelData, SourceModelData,
     TargetModelData,

main/src/infrastructure/data/target_model_data.rs

@@ -9,8 +9,8 @@ use crate::application::{
 use crate::core::default_util::{is_default, is_none_or_some_default};
 use crate::core::notification;
 use crate::domain::{
-    ActionInvocationType, ExtendedProcessorContext, FxAnchor, ProcessorContext, SoloBehavior,
-    TouchedParameterType, TrackExclusivity, TransportAction, VirtualFx, VirtualTrack,
+    ActionInvocationType, ExtendedProcessorContext, FxAnchor, SoloBehavior, TouchedParameterType,
+    TrackExclusivity, TransportAction, VirtualFx, VirtualTrack,
 };
 use derive_more::{Display, Error};
 use semver::Version;

main/src/infrastructure/ui/header_panel.rs

@@ -22,9 +22,7 @@ use crate::application::{
     SharedSession, VirtualControlElementType, WeakSession,
 };
 use crate::core::when;
-use crate::domain::{
-    ExtendedProcessorContext, MappingCompartment, OscDeviceId, ProcessorContext, ReaperTarget,
-};
+use crate::domain::{ExtendedProcessorContext, MappingCompartment, OscDeviceId, ReaperTarget};
 use crate::domain::{MidiControlInput, MidiFeedbackOutput};
 use crate::infrastructure::data::{ExtendedPresetManager, OscDevice, SessionData};
 use crate::infrastructure::plugin::{
@@ -318,7 +316,8 @@ impl HeaderPanel {
     fn invalidate_compartment_combo_box(&self) {
         self.view
             .require_control(root::ID_COMPARTMENT_COMBO_BOX)
-            .select_combo_box_item_by_index(self.active_compartment().into());
+            .select_combo_box_item_by_index(self.active_compartment().into())
+            .unwrap();
     }
 
     fn invalidate_preset_auto_load_mode_combo_box(&self) {
@@ -327,13 +326,15 @@ impl HeaderPanel {
         if self.active_compartment() == MappingCompartment::MainMappings {
             label.show();
             combo.show();
-            combo.select_combo_box_item_by_index(
-                self.session()
-                    .borrow()
-                    .main_preset_auto_load_mode
-                    .get()
-                    .into(),
-            );
+            combo
+                .select_combo_box_item_by_index(
+                    self.session()
+                        .borrow()
+                        .main_preset_auto_load_mode
+                        .get()
+                        .into(),
+                )
+                .unwrap();
         } else {
             label.hide();
             combo.hide();

main/src/infrastructure/ui/mapping_header_panel.rs

@@ -243,7 +243,8 @@ impl MappingHeaderPanel {
     fn invalidate_activation_type_combo_box(&self, item: &dyn Item) {
         self.view
             .require_control(root::ID_MAPPING_ACTIVATION_TYPE_COMBO_BOX)
-            .select_combo_box_item_by_index(item.activation_type().into());
+            .select_combo_box_item_by_index(item.activation_type().into())
+            .unwrap();
     }
 
     fn invalidate_activation_setting_1_controls(&self, item: &dyn Item) {
@@ -260,7 +261,8 @@ impl MappingHeaderPanel {
                 let param_index = item.program_condition().param_index();
                 self.view
                     .require_control(root::ID_MAPPING_ACTIVATION_SETTING_1_COMBO_BOX)
-                    .select_combo_box_item_by_index(param_index as _);
+                    .select_combo_box_item_by_index(param_index as _)
+                    .unwrap();
             }
             _ => {}
         };
@@ -280,7 +282,8 @@ impl MappingHeaderPanel {
                 let program_index = item.program_condition().program_index();
                 self.view
                     .require_control(root::ID_MAPPING_ACTIVATION_SETTING_2_COMBO_BOX)
-                    .select_combo_box_item_by_index(program_index as _);
+                    .select_combo_box_item_by_index(program_index as _)
+                    .unwrap();
             }
             _ => {}
         };