Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.26.0 release does not follow semver #246

Closed
liayn opened this issue Jul 28, 2017 · 6 comments
Closed

1.26.0 release does not follow semver #246

liayn opened this issue Jul 28, 2017 · 6 comments

Comments

@liayn
Copy link
Contributor

liayn commented Jul 28, 2017

The build folder has been moved to dist, which is a major breaking change. This breaks automated scripts! Thus the version must be 2.0.0.

@pmb0 I suggest to:

  • let a 2.0.0 follow immediately
  • release a 1.27.0 which uses the old release scripts
@liayn
Copy link
Contributor Author

liayn commented Jul 28, 2017

Note: This is the second time such a mistake happens with Shariff. Please make sure Heise gets this straight for the future.

@pmb0
Copy link
Member

pmb0 commented Jul 28, 2017 •
edited
Loading

Renaming ./dist to ./build and releasing 1.26.1 should fix this -- right?

@pmb0
Copy link
Member

pmb0 commented Jul 28, 2017

No, they are git-ignored now. I will publish a new release that contains ./build soon. After that i will release 2.0.0.

pmb0 added a commit that referenced this issue Jul 28, 2017
@pmb0
Add missing build directory. [#246]
53f14b5
pmb0 added a commit that referenced this issue Jul 28, 2017
@pmb0
Merge branch 'release/1.26.1'
8d81b7e 
* release/1.26.1:
  release 1.26.1
  Add missing build directory. [#246]
pmb0 added a commit that referenced this issue Jul 28, 2017
@pmb0
Merge tag '1.26.1' into develop
c649ac1 
* Added missing ./build directory. [#246]

* tag '1.26.1':
  release 1.26.1
@pmb0
Copy link
Member

pmb0 commented Jul 28, 2017

Is v1.26.1 fine for you?

@liayn
Copy link
Contributor Author

liayn commented Jul 28, 2017

Sure. As you like. Just make sure that people don't die if they update within v1. ;-)

@liayn
Copy link
Contributor Author

liayn commented Jul 28, 2017

Thanks for taking care quickly.

@liayn liayn closed this as completed Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liayn @pmb0