Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context aware interfaces to Driver #9

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Add context aware interfaces to Driver #9

merged 1 commit into from
Sep 21, 2018

Conversation

asdine
Copy link
Contributor

@asdine asdine commented Sep 20, 2018 •
edited
Loading

EDIT:
This PR allows using a sqalx.Driver as an ExecerContext etc. Driver is an interface that contains methods that are found in an *sqlx.DB and *sqlx.Tx. ExecerContext and such were missing from the interface and this was preventing to use their respective methods from a Driver.

@asdine asdine requested review from tealeg and yaziine September 20, 2018 16:03
tealeg
tealeg approved these changes Sep 21, 2018
View reviewed changes
Copy link

@tealeg tealeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to see here ;-) Presumably in support of some bigger change? It's always good to write a "why" statement in the PR description, even for something trivial.

@asdine asdine merged commit 21a5f51 into master Sep 21, 2018
@asdine asdine deleted the context-methods branch September 21, 2018 07:51
@asdine asdine mentioned this pull request Sep 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tealeg tealeg tealeg approved these changes

@yaziine yaziine yaziine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asdine @tealeg @yaziine