adds ssm backend #71
adds ssm backend #71
Conversation
|
Thanks for the review! Will get these changes in soon. |
the amazon ssm api dictates this, and, 10 is the max
steamrolla
force-pushed
the
ssm-backend
branch
from
f1c923d to
fc24dfb
Compare
|
@rogpeppe, I think I got them all! Let me know if anything still needs changed. |
|
|
||
| before_script: | ||
| - docker run -d -p 2379:2379 quay.io/coreos/etcd /usr/local/bin/etcd -advertise-client-urls http://0.0.0.0:2379 -listen-client-urls http://0.0.0.0:2379 | ||
| - docker run -d -p 8500:8500 --name consul consul | ||
| - docker run -d -p 8200:8200 --cap-add=IPC_LOCK -e 'VAULT_DEV_ROOT_TOKEN_ID=root' -e 'VAULT_DEV_LISTEN_ADDRESS=0.0.0.0:8200' vault:0.9.6 | ||
| - docker run -d -p 8200:8200 --cap-add=IPC_LOCK -e 'VAULT_DEV_ROOT_TOKEN_ID=root' -e 'VAULT_DEV_LISTEN_ADDRESS=0.0.0.0:8200' vault:0.9.6 |
There was a problem hiding this comment.
Perhaps add the final newline here?
| cache map[string][]byte | ||
| } | ||
|
|
||
| func NewBackend(ssm ssmiface.SSMAPI, path string) *Backend { |
There was a problem hiding this comment.
Please add a doc comment explaining what this does and how this backend interacts with SSM (presumably path specifies a path within the SSM parameters, but it would be great to be explicit about this).
Also, I think it would be better to be consistent with the other backends and return confita.Backend here (and unexport the Backend struct type), as I don't think we want to add extra methods in the future, and this is all about returning a confita backend instance.
| ssmiface.SSMAPI | ||
| } | ||
|
|
||
| func (_m *mockSSM) GetParametersByPathWithContext(_a0 context.Context, _a1 *ssm.GetParametersByPathInput, _a2 ...request.Option) (*ssm.GetParametersByPathOutput, error) { |
There was a problem hiding this comment.
I don't understand why all these variables are named with leading underscores.
This looks like generated code, but I don't see that there's really a need for generated code here.
Adds Amazon SSM's Parameters as a backend.
There are many ways the calls could be made to Amazon, but, just starting with the simplest now. User just gives the path for their parameter store. Can be easily changed in the future if people want to use it in a different way. Very open to ideas here.