🧪 Refactor cypress tests (part 3) #5592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
|
@Felienne this was meant as a draft! |
Annelein
commented
Jun 10, 2024
tests/cypress/e2e/for-teacher_page/class_page/other_buttons.cy.js
Outdated
Show resolved
Hide resolved
Annelein
commented
Jun 12, 2024
tests/cypress/e2e/for-teacher_page/customize_class_page/preview_class.cy.js
Outdated
Show resolved
Hide resolved
Annelein
commented
Jun 12, 2024
tests/cypress/e2e/for-teacher_page/customize_class_page/quiz_parsons.cy.js
Outdated
Show resolved
Hide resolved
|
@jpelay added the tests for second teachers! so its ready |
jpelay
approved these changes
Jun 17, 2024
| @@ -1,195 +0,0 @@ | |||
| import { loginForTeacher } from '../../tools/login/login.js' | |||
|
|
|||
| describe('customize class page', () => { | |||
There was a problem hiding this comment.
Good call grouping these in customize_class!
| @@ -2,21 +2,20 @@ import {loginForTeacher} from '../../tools/login/login.js' | |||
| import {goToEditAdventure} from '../../tools/navigation/nav.js' | |||
| import { createAdventure } from '../../tools/adventures/adventure.js' | |||
|
|
|||
| describe('Preview button test', () => { | |||
| it('passes', () => { | |||
| it('Preview button test', () => { | |||
There was a problem hiding this comment.
I think this one should say "Remove button test"
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the entire
for-teacher folderfor #4027 :customize-adventure folderonly data-cy and .it() refactoringHow to test
I think the best way is to click around the for-teacher page tests and see if they are structured better, readabilty improved and if they cover testing the whole for-teacher page