Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪲 attempt to fix 2 columns adventures #5485

Merged
merged 3 commits into from
May 7, 2024
Merged

🪲 attempt to fix 2 columns adventures #5485

merged 3 commits into from
May 7, 2024

Conversation

hasan-sh
Copy link
Collaborator

@hasan-sh hasan-sh commented Apr 29, 2024 •
edited
Loading

Fixes #5473

@hasan-sh hasan-sh marked this pull request as ready for review May 6, 2024 14:22
@jpelay
Copy link
Member

jpelay commented May 6, 2024

Hi Hasan! Can you add a way in which I can test this PR?

@jpelay jpelay self-assigned this May 6, 2024
@hasan-sh
Copy link
Collaborator Author

hasan-sh commented May 7, 2024

Hi Hasan! Can you add a way in which I can test this PR?

One example would be what Marleen discovered; https://hedy.org/public-adventures?level=17&lang=&tag=&search=#Tic%20Tac%20Toe%20with%20drawing%20turtle

Just copy the content of this adventure and create it locally! Any other long adventures could also work as a test case!

This was referenced May 7, 2024
Open
Open
jpelay
jpelay approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This does solve the issue at hand, and I think it's best to leave the others for other PRs.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 7, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 438b920 into main May 7, 2024
12 checks passed
@mergify mergify bot deleted the adv-columns-fix branch May 7, 2024 18:02
@mergify Mergify
Copy link
Contributor

mergify bot commented May 7, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpelay jpelay jpelay approved these changes

Assignees

@jpelay jpelay

Labels
under-review
Projects
Hedy organization board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🪲 Public adventure I posted looks very weird
2 participants
@hasan-sh @jpelay