Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜 Use {play} template instead of literal play in music adventure #5436

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

bobvanderlinden
Copy link
Contributor

Currently when opening the music adventure level 1 in Nederlands you'll get the following instruction:

In dit level leer je het speel commando te gebruiken om een muzieknoot te spelen!

Though in the example right next to it, it says:

play C4
...

This example is English and not Nederlands. It should say:

speel C4
...

Other levels of the music adventure do correctly use the speel command. There {play} template is indeed used. I applied the same template to level 1.

Let me know if I should also create an issue for this PR.

How to test

Follow these steps to verify this PR works as intended:

Checklist

  • Contains one of the PR categories in the name
  • Describes changes in the format above
  • Links to an existing issue or discussion
  • Has a "How to test" section

Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR @bobvanderlinden, welcome to Hedy!! Well done diving into the yamls to find this and cross referencing with other levels!

Other languages, sadly, suffer from the same issue (they got copied over from the same source), see f.e.

Would you mind fixing it in other languages too? 🙏

@bobvanderlinden bobvanderlinden changed the title 📜 Use {play} template instead of literal play in NL music adventure 📜 Use {play} template instead of literal play in music adventure Apr 19, 2024
@bobvanderlinden
Copy link
Contributor Author

Good one! Didn't even notice before. I've search-replaced all instances of this example 👍

Copy link
Contributor

mergify bot commented Apr 19, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 582b0af into hedyorg:main Apr 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants