-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪲 duplicate adventures #5385
🪲 duplicate adventures #5385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Fixes #5375
This PR changes how adventures are created. We don't need to "store" the adventures unless the teacher appllies some changes. This means whenever we redirect the teacher to the customize-adventure page, we simply initialize an adventrue, save in the current session, and if they apply a change, then we basically save it in our DB.
Not only does this prevent the issue I'm fixing, but also reduce the number of trial adventures created by teachers.
Moreover, the only downside is that teachers would have to write out the name themselves, however, this may not be a min-point afterall since giving default names is kinda encouraging creating more, and more will be created just because it becomes easy to do so!
How to test?
Create an adventure from the