💻 Redesign go back button #5169
Conversation
There was a problem hiding this comment.
Hopefull it'll be used, but i want to validate that by giving the btn a generic class (since you give different IDs in different pages!) and add it to the https://github.com/hedyorg/hedy/blob/main/static/js/user-activity.ts#L6.
Further, I have just two remarks:
- There's one page that still needs to be updated:
/for-teachers/create-accounts/{class_id} - for Arabic (or RTL languages), we need to horizontally flip the arrow!
|
@hasan-sh the tests are depending on that pull request, or is there a way around? |
|
@hasan-sh if you approve it can be merged :) |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Fixes #5155 Depends-On: #5156 Added a general "Go back" button to: `/customize-class` `/live-stats` `/customize-adventure` `/grid-overview` and `/for-teachers/class` <img width="1440" alt="Screenshot 2024-02-29 at 14 34 15" src="https://github.com/hedyorg/hedy/assets/48122190/1e397636-61eb-4257-843e-e8cae421627e">
Fixes #5155
Depends-On: #5156
Added a general "Go back" button to:
/customize-class/live-stats/customize-adventure/grid-overviewand/for-teachers/class