[BUG] Fix broken tests #4882
Merged
[BUG] Fix broken tests #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felienne
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Thanks for the quick fix @ToniSkulj!!
#4881 has similar issues, I hope this fixes those too!
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
mergify
bot
deleted the
4863-bug-new-exception-system-creates-issues-in-skip-faulty
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4863.
After #4838, the processing of the string was done after setting the input string on the source map.
This led to 2 tests failing.
This PR first uses process_input_string before setting the input on the source map. Fixing the failing tests.