[LANGUAGE] Check translations #4867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This reverts commit 310df05.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
we used to show only non-latin languages in their lang default but we now do all of them, can be removed!
|
(this branches of of the isvalid one, I will rebase when it is merged!) |
for more information, see https://pre-commit.ci
…into check-translations
for more information, see https://pre-commit.ci
|
Superseded by #4875 |
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
(This is a redo of #4867 which contained some commits now already on main) Since #4828 translation features are more prominently visible, so I figured we need to do a bit better. This actually changes some conceptual assumptions, so let's document here: * Programs that have a ParseError or contain Placeholders, or have indentation issues, still cannot be translated (since they can't be parsed and then we don't have a tree to work wtih) * All other errors however create a parsetree with error nodes, and thus... can just be translated keeping the error nodes, so that is what we now do! **How to test** Try a program with an error production, f.e. in German, level 7: `repeat 3 times 'Hedy macht Spaß!'` Main shows an error: <img width="724" alt="image" src="https://github.com/hedyorg/hedy/assets/1003685/2ec4d071-9c1e-4e10-9a9b-606024e42e37"> This PR translates the code: <img width="693" alt="image" src="https://github.com/hedyorg/hedy/assets/1003685/4d3c4410-900c-4b98-99f2-502672e42420">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More extensive testing of the translation part (which is now a lot more exposed since #4828)