-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement customizable classes (attempt 2) #1317
Conversation
Hi @TiBiBa, The overview looks great, just a few small UX issues:
Now by default all tickmarks are off: That is a weird default because I would say conceptually all adventures are "on" at the start. Can we turn all marks on? Or are all adventure off by default for a new class? |
@@ -7,6 +7,7 @@ | |||
TOKENS = dynamo.Table(storage, 'tokens', 'id') | |||
PROGRAMS = dynamo.Table(storage, 'programs', 'id', indexed_fields=['username']) | |||
CLASSES = dynamo.Table(storage, 'classes', 'id', indexed_fields=['teacher', 'link']) | |||
PREFERENCES = dynamo.Table(storage, 'preferences', 'id') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I love the name preferences because we have been calling it customizations and preferences is quite generic. Shall we rename the table customization or class-customization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would indeed be more straight forward. Will rename all variables (and the db) into customizations.
I will implement a back button and change the color of the active button (in combination with removing the header). By default they are all turned off (if any settings exist for the class/level combination). If no restriction exists for the class/level than all adventures are shown automatically. |
Provide a general summary of your changes in the Title of the PR
Description
In this PR we implement customizable classes. Enabling teachers to select specific adventures, hide example programs and/or hide levels. This feature will allow teachers to customize their teaching and restrict students to specific levels and/or adventures helping the teaching. We also fix a small bug where the incorrect active page on the menubar was shown.
Fix for
This PR fixed #1299 and fixed #1304.
How to test
Log in as a teacher account and navigate to a class. Choose the "customize class" button and select preferences for each level. Then, on a student account (enrolled to this class) navigate to the levels for which preferences where selected and notice the created restrictions.
Checklist
If you're unsure about any of these, don't hesitate to ask. We're here to help!