forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 6
cmake: Rebase and backport C++20 changes #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cory Fields <[email protected]> Co-authored-by: Vasil Dimov <[email protected]>
Co-authored-by: Cory Fields <[email protected]>
To configure CMake for cross-compiling, use
`--toolchain depends/${HOST}/share/toolchain.cmake` command-line option.
Keep this commit at the top when rebasing.
|
Friendly ping @TheCharlatan @fanquake @theuni @vasild @pablomartin4btc @m3dwards :) |
TheCharlatan
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ACK
|
Thank you for the reviewing! This branch has been force pushed into the https://github.com/hebasto/bitcoin/tree/cmake-staging. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only goal of this PR is to backport changes from bitcoin#28349.
As they include changes to the depends build system, I decided to combine C++20 changes in CMake stuff with the rebasing of the
cmake-stagingbranch on top of the master @ 3e691258d8789a4a89cce42e7e71b130491594d7 (the fixup/autosquash approach doesn't work well as it introduces a number of conflicts).For me, the
git diff cmake-staging..231208-linear -- CMakeLists.txtgives:Changes from bitcoin#28894 have been backported as well.
What to test?