Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change methods names to snake case #571

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Change methods names to snake case #571

merged 1 commit into from
Jul 7, 2023

Conversation

guilhermeleobas
Copy link
Contributor

Fixes #570

@guilhermeleobas guilhermeleobas added code quality Code quality heavydb Related to heavydb server labels Jun 30, 2023
@guilhermeleobas guilhermeleobas self-assigned this Jun 30, 2023
@guilhermeleobas guilhermeleobas marked this pull request as ready for review July 3, 2023 17:08
@guilhermeleobas guilhermeleobas requested a review from pearu July 6, 2023 12:42
pearu
pearu approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @guilhermeleobas!

@guilhermeleobas guilhermeleobas merged commit 6056804 into heavyai:main Jul 7, 2023
@guilhermeleobas guilhermeleobas deleted the guilhermeleobas/snake_case branch July 7, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearu pearu pearu approved these changes

Assignees

@guilhermeleobas guilhermeleobas

Labels
code quality Code quality heavydb Related to heavydb server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert methods to snake case
2 participants
@guilhermeleobas @pearu