Emit warning message when version(Numba LLVM) != version(clang) #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermeleobas
added
enhancement
pearu
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
LGTM! Thanks, @guilhermeleobas!
A warning: here we use the private numba symbol _min_llvm_version. Would it make sense to move the import statement under the compiler method?
…M version shipped with Numba and the clang version selected
guilhermeleobas
force-pushed
the
guilhermeleobas/add_warning_msg
branch
from
7493901 to
713f8a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warning message when there's a version mismatch between the LLVM version shipped with Numba and the clang version selected