Add HeavyDBTimestampType

[tupui]

No description provided.

[guilhermeleobas]

Hi Pamphile, can you fix the flake8 failure and rewrite the test?

[guilhermeleobas]

Can you rebase with RBC main branch? Also, restrict the test to heavydb 6.0 or greater.

[tupui]

I added the skip. For the rebase, this branch is already up to date with main

[guilhermeleobas]

@tupui, to fix the current failure, apply the following patch

diff --git a/rbc/heavydb/timestamp.py b/rbc/heavydb/timestamp.py
index f1764aa..62f6224 100644
--- a/rbc/heavydb/timestamp.py
+++ b/rbc/heavydb/timestamp.py
@@ -32,6 +32,9 @@ class HeavyDBTimestampType(typesystem.Type):
         return 'Timestamp'
 
 
+extending.make_attribute_wrapper(TimestampNumbaType, 'time', 'time')
+
+
 @extending.type_callable(Timestamp)
 def type_heavydb_timestamp(context):
     def typer(arg):
diff --git a/rbc/tests/heavydb/test_timestamp.py b/rbc/tests/heavydb/test_timestamp.py
index 6792591..37cbad2 100644
--- a/rbc/tests/heavydb/test_timestamp.py
+++ b/rbc/tests/heavydb/test_timestamp.py
@@ -33,7 +33,7 @@ def test_timestamp(heavydb):
     def timestamp_extract(x, y):
         set_output_row_size(len(x))
         for i in range(len(x)):
-            y[i] = x[i]
+            y[i] = x[i].time
         return len(x)
 
     heavydb.register()
@@ -41,4 +41,4 @@ def test_timestamp(heavydb):
     table = 'time_test'
     query = f'select * from table(timestamp_extract(cursor(select t1 from {table})));'
     _, result = heavydb.sql_execute(query)
-    assert list(result) == [1, 1654268400000]
+    assert list(result) == [(1,), (1654268400000000000,)]

[tupui]

@guilhermeleobas can you have another look?

[guilhermeleobas]

Thanks for the work, Pamphile. I have only one commenting regarding the packaging package.

[tupui]

I made the changes @guilhermeleobas

[guilhermeleobas]

Thanks Pamphile. With the introduction of packaging, perhaps one should revisit all the test files and fix the version comparison to use the new library.

[tupui]

Yes that would be a good thing to do IMO. Thanks for the review 😃

@pearu do you want to have a look?