Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heavydb_ -> HEAVYDB_ #471

Merged
merged 1 commit into from
Mar 29, 2022
Merged

heavydb_ -> HEAVYDB_ #471

merged 1 commit into from
Mar 29, 2022

Conversation

guilhermeleobas
Copy link
Contributor

@guilhermeleobas guilhermeleobas self-assigned this Mar 29, 2022
@guilhermeleobas guilhermeleobas mentioned this pull request Mar 29, 2022
Merged
@guilhermeleobas guilhermeleobas linked an issue Mar 29, 2022 that may be closed by this pull request
Capitalize heavydb_ env prefix in rbc_test.yml #472
Closed
@guilhermeleobas guilhermeleobas requested a review from pearu March 29, 2022 17:19
pearu
pearu approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Notice that CI tests are skipped. I guess we can trust this as we'll notice if something is wrong in subsequent PRs..

@guilhermeleobas guilhermeleobas merged commit 298af71 into heavyai:master Mar 29, 2022
@guilhermeleobas guilhermeleobas deleted the guilhermeleobas/cap_heavydb branch March 29, 2022 20:46
@guilhermeleobas guilhermeleobas mentioned this pull request Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearu pearu pearu approved these changes

Assignees

@guilhermeleobas guilhermeleobas

Labels
code quality Code quality skip-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capitalize heavydb_ env prefix in rbc_test.yml
2 participants
@guilhermeleobas @pearu