Fix issue #467 - Move imports to rbc.heavydb #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermeleobas
force-pushed
the
guilhermeleobas/issue467
branch
from
202c45f to
d884525
Compare
tupui
reviewed
Mar 29, 2022
guilhermeleobas
force-pushed
the
guilhermeleobas/issue467
branch
from
c9da34e to
5335a1f
Compare
guilhermeleobas
force-pushed
the
guilhermeleobas/issue467
branch
from
5335a1f to
8056911
Compare
tupui
approved these changes
Mar 29, 2022
pearu
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
LGTM!
Re @tupui comment: Ultimately, why don't we just move heavydb into heavydb_backend?
Yes, I think it makes sense but as a follow-up PR:
- move
heavydb.pytoheavydb_backend/remote_heavydb.py(or suggest a better name) - rename
heavydb_backend/toheavydb/ - expose the UI of
heavydb.pyviaheavydb/__init__.py
I've messed up during rebase 😆 |
This was referenced Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
rbc.heavai.*torbc.heavydb.*rbc/tests/heavyaitorbc/tests/heavydbrbc/tests/heavydb/test_imports.pythat ensures imports forArray,ArrayPointer,Bytes,Columnare working as expected. Some of those imports are used in UD[T]Fs to create objects at runtime, others are used internally in jitted functions.