Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: more information in message when raising when no runtime #425

Merged
merged 3 commits into from
Feb 2, 2022

Conversation

tupui
Copy link
Contributor

@tupui tupui commented Feb 2, 2022

If OmniSciDB is started without enabling support for UD[T]F an error is raised. The message is improved by inviting users to enable the feature.

Traceback (most recent call last):
  File "/opt/homebrew/Caskroom/mambaforge/base/envs/rbc-dev/lib/python3.9/site-packages/IPython/core/interactiveshell.py", line 3251, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-3-adb71b2ceb17>", line 13, in <module>
    _, result = omni.sql_execute(query)
  File "/Users/tupui/Documents/Quansight/Projects/Omnisci/rbc/rbc/omniscidb.py", line 616, in sql_execute
    self.register()
  File "/Users/tupui/Documents/Quansight/Projects/Omnisci/rbc/rbc/omniscidb.py", line 1010, in register
    return self._register()
  File "/Users/tupui/Documents/Quansight/Projects/Omnisci/rbc/rbc/omniscidb.py", line 1120, in _register
    return self.thrift_call(
  File "/Users/tupui/Documents/Quansight/Projects/Omnisci/rbc/rbc/omniscidb.py", line 356, in thrift_call
    return client(Omnisci={name: args})['Omnisci'][name]
  File "/Users/tupui/Documents/Quansight/Projects/Omnisci/rbc/rbc/thrift/client.py", line 205, in __call__
    r = mth(*query_args)
  File "/opt/homebrew/Caskroom/mambaforge/base/envs/rbc-dev/lib/python3.9/site-packages/thriftpy2/thrift.py", line 219, in _req
    return self._recv(_api)
  File "/opt/homebrew/Caskroom/mambaforge/base/envs/rbc-dev/lib/python3.9/site-packages/thriftpy2/thrift.py", line 251, in _recv
    raise v
rpc-client-rh2o9pne.TMapDException: TMapDException(error_msg='Runtime extension functions registration is disabled.')

There is tons of extra things getting printed but I don't know where it's coming from and if we can remove them easily.

'k8-sse3' is not a recognized processor for this target (ignoring processor)
'+sse2' is not a recognized feature for this target (ignoring feature)
'+cx16' is not a recognized feature for this target (ignoring feature)
'+sahf' is not a recognized feature for this target (ignoring feature)
'-tbm' is not a recognized feature for this target (ignoring feature)
'-avx512ifma' is not a recognized feature for this target (ignoring feature)
'-sha' is not a recognized feature for this target (ignoring feature)
'-gfni' is not a recognized feature for this target (ignoring feature)
'-fma4' is not a recognized feature for this target (ignoring feature)
'-vpclmulqdq' is not a recognized feature for this target (ignoring feature)
'-prfchw' is not a recognized feature for this target (ignoring feature)
'+bmi2' is not a recognized feature for this target (ignoring feature)
'-cldemote' is not a recognized feature for this target (ignoring feature)
'+fsgsbase' is not a recognized feature for this target (ignoring feature)
'-ptwrite' is not a recognized feature for this target (ignoring feature)
...

@tupui tupui added enhancement New feature or request heavydb Related to heavydb server labels Feb 2, 2022
@tupui tupui self-assigned this Feb 2, 2022
@pearu
Copy link
Contributor

pearu commented Feb 2, 2022

Re the tons of extra things: these warnings appear when the server and client LLVM versions are different.
Some of these can be silenced by updating the map:
https://github.com/xnd-project/rbc/blob/02ca2d3b045bd7cf4b1ee5d1a9e25853ca0dd420/rbc/irtools.py#L104-L112

Copy link
Contributor

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @tupui!

The notebook CI is fixed via 45a7dd5

@pearu pearu merged commit 49e9771 into heavyai:master Feb 2, 2022
@tupui tupui deleted the tupui/enable_udf_exception branch February 2, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request heavydb Related to heavydb server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants