-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TailwinCSS 3 support #1762
base: main
Are you sure you want to change the base?
Add TailwinCSS 3 support #1762
Conversation
@carlosantoniodasilva It would be great if this PR would further be looked into and proceeded with a merge. |
I'm not sure how getting a pull request works in this project, but I've read through these commits and they look good to me. |
any news? |
Nope( |
I'd love if this was available too! |
Hope this get merged someday soon :)! |
``` | ||
abbr[title=required] { | ||
@apply !text-red-500 no-underline; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @loqimean! Thanks for your contribution!
I noticed that we can use the following snippet at the config/locales/simple_form.en.yml
file and override the abbr
props
required:
# text: "required"
# mark: "*"
html: '<abbr class="text-red-500 no-underline" title="required">*</abbr>'
btw, you should add the simple_form.*.yml into the content array at the tailwind.config.js
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, nice idea, can you add it to the PR?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure will add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loqimean I ended up creating a gem to install the tailwind theme and added the locale file automatically. (It also has support for bulma css)
is this PR dead? |
Would be ask it for an author of a gem, because I'm ready to update it and merge |
I love this. Thank you! Has anyone had any trouble using it? |
Hey! I've developed a gem to support simple_form themes for modern CSS frameworks. We currently support Bulma and Tailwind CSS. Feel free to contribute by opening issues or pull requests. See you soon! https://github.com/JuanVqz/simple_form-theme |
Add support for the TailwindCSS 3 framework. Now is supporting horizontal forms. It looks like this: