Replace [data-turbo-cache=false] with [data-turbo-temporary] #5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should work with Turbo >= 7.3.0 and won't work with Turbo < 7.3.0 Could just support latest version of turbo? (break in old Turbo) Or stick with old turbo? (deprecation warnings on new Turbo) Could have a turbo compatibility layer: <div id="error_explanation" <%= Devise::TurboCompat.gte_730? && 'data-turbo-temporary' || 'data-turbo-cache="false"' %>>Given that Turbo is a Js library, it seems tricky to find an automatic way to support different versions of turbo. Would then have to be configured by either an env var or a devise configuration option? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the suggestion from issue #5662
The turbo drive's attribute
[data-turbo-cache=false]was deprecated in favor ofdata-turbo-temporary