Skip to content

Fixed missing migration to dedicated deprecator#5628

Merged
carlosantoniodasilva merged 1 commit intoheartcombo:mainfrom
soartec-lab:fix/dedicated_active_support_deprecation
Sep 13, 2023
Merged

Fixed missing migration to dedicated deprecator#5628
carlosantoniodasilva merged 1 commit intoheartcombo:mainfrom
soartec-lab:fix/dedicated_active_support_deprecation

Conversation

@soartec-lab
Copy link
Contributor

This is a follow-up to the PR below:

rails has deprecated the use of ActiveSupport::Deprecation in singleton in this PR, so devise has defined its own Deprecator in response to this, but there was an omission in the correction. So I fixed it.

Please note that a PR has been created that will discontinue support for EOL rails versions, and the files modified this time may also be deleted.

#5600

@soartec-lab
Copy link
Contributor Author

I think the failing tests will be fixed in #5622

@carlosantoniodasilva carlosantoniodasilva merged commit f6e73e5 into heartcombo:main Sep 13, 2023
@carlosantoniodasilva
Copy link
Member

Thanks!

carlosantoniodasilva added a commit that referenced this pull request Oct 10, 2023
…t_deprecation

Fixed missing migration to dedicated deprecator
carlosantoniodasilva added a commit that referenced this pull request Oct 10, 2023
…t_deprecation

Fixed missing migration to dedicated deprecator
carlosantoniodasilva added a commit that referenced this pull request Oct 10, 2023
…t_deprecation

Fixed missing migration to dedicated deprecator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants