Closed
Conversation
marcoroth
force-pushed
the
intoduce-devise-deprecator
branch
from
a50955f to
a78ccc1
Compare
marcoroth
force-pushed
the
intoduce-devise-deprecator
branch
from
a78ccc1 to
50e35df
Compare
marcoroth
commented
Apr 21, 2023
|
|
||
| include Devise::DeprecatedConstantAccessor | ||
| deprecate_constant "BLACKLIST_FOR_SERIALIZATION", "Devise::Models::Authenticatable::UNSAFE_ATTRIBUTES_FOR_SERIALIZATION" | ||
| deprecate_constant "BLACKLIST_FOR_SERIALIZATION", "Devise::Models::Authenticatable::UNSAFE_ATTRIBUTES_FOR_SERIALIZATION", deprecator: Devise.deprecator |
piperswe
approved these changes
May 3, 2023
piperswe
left a comment
piperswe
left a comment
There was a problem hiding this comment.
Looks good! (not a maintainer, just trying to push this along) Hopefully this gets merged before Rails 7.1's release.
Author
|
I just noticed this is a duplicate of #5583. I'm going to close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 7.1 will deprecate the usage of the singleton
ActiveSupport::Deprecationinstance. This change was introduced via rails/rails#47354.This pull request defines
Devise.deprecatorfor the gem and uses it throughout the codebase.Resolves #5589
Inspired by rails/sprockets-rails#517