Skip to content

Conversation

@vyncent-t
Copy link
Contributor

This PR fixes the issue that causes the app-catalog origin field to render as "unknown" when viewed in the plugin tab in the settings.

Currently, almost all other plugins in our plugin repo have the name standard as @headlamp-k8s/plugin-name within its package.json file. In the main project, for the settings view, we parse the name field to extract an author for the origin field.
Currently the name field for the app-catalog just reads app-catalog thus rendering unknown in the settings.

If there is not a specific reason why we must keep it as app-catalog then these changes should fix this.

Fixes kubernetes-sigs/headlamp#4101

Changes

  • Update the app-catalog package.json name field from app-catalog to @headlamp-k8s/app-catalog

How to test

  • On main install the latest app-catalog plugin
  • Navigate to settings then navigate to the plugins tab
  • Notice that app-catalog origin field renders unknown
  • Close the app and check out these changes
  • Install and run these changes via run npm i and npm run start
  • Navigate back to settings then navigate to the plugins tab
  • Notice that the origin field should now render headlamp-k8s and not unknown

Images

Before

image

After

image

@vyncent-t vyncent-t self-assigned this Oct 29, 2025
@vyncent-t vyncent-t force-pushed the fix-shipped-plugins-origin-unknown branch from ee0b1a3 to 48da92c Compare October 29, 2025 20:05
@vyncent-t vyncent-t added the app-catalog app-catalog (helm charts) plugin related issues label Oct 29, 2025
@vyncent-t vyncent-t requested a review from illume October 29, 2025 22:04
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks!

@illume illume merged commit 093f556 into main Nov 3, 2025
9 checks passed
@illume illume deleted the fix-shipped-plugins-origin-unknown branch November 3, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app-catalog app-catalog (helm charts) plugin related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App: Shipped app-catalog and prometheus show origin 'unknown'

3 participants