-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Enhance Table component with column resizing functionality #2773
base: main
Are you sure you want to change the base?
Conversation
ec8f156
to
722a69c
Compare
Signed-off-by: Charles <[email protected]>
Signed-off-by: Charles <[email protected]>
85b5bec
to
d10f592
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for opening a PR!
When I tried it, it behaves a bit weird, there's something wrong with the resizing
Recording.2025-01-23.135103.mp4
I'm guessing it's because of the custom table layout we're using so it might be a lot harder to get it right
Hi, I have tried several different solutions. The reason why the columns next to each other change with the adjustment is that the width of the table is fixed. If we want to ensure that the adjustment does not affect other columns, i cannot fix the width of the table. Adjusting the column width will cause the page to stretch. We can discuss which solution is better. In the first solution, I found that the mouse position and the operation handle position are different, and the column width will jump with the text wrapping and unwrapping. 2025-01-24.11-31-00.mp4 |
Signed-off-by: Charles <[email protected]>
Signed-off-by: Charles <[email protected]>
I pushed the code for the second solution to pr, but I can't fix the width of the page. Maybe all the places where it is used need to be changed, which will be a big change. I'm not sure whether to continue. |
fix #2652
Dear maintainers, this is my first time contributing code to this project, please forgive me if there are any problems. Thank you for your work.