Skip to content

Commit

Permalink
frontend: Use ISO format for dates tests
Browse files Browse the repository at this point in the history 
Node has changes how they format the dates when using "toLocaleString",
introducing a special character (U+202f) instead of a space.
Our first instinct was to lower the Node version and wait for a fix,
but according to [1], Node doesn't seem to be reverting it soon and
mentions one shouldn't use localized strings for testing...

So, in order to avoid this, this patch makes the dates show up in
ISO format.

[1] nodejs/node#46123
  • Loading branch information
@joaquimrocha
joaquimrocha committed Jan 15, 2023
1 parent 081bf6b commit b441134
Show file tree
Hide file tree
Showing 18 changed files with 83 additions and 82 deletions.
6 changes: 3 additions & 3 deletions frontend/src/components/common/Resource/__snapshots__/MetadataDisplay.stories.storyshot
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ exports[`Storyshots Resource/MetadataDisplay Metadata Display 1`] = `
<span
class="MuiTypography-root makeStyles-valueLabel MuiTypography-body1"
>
6/2/2021, 12:00:00 AM UTC
2021-06-02T00:00:00.000Z
</span>
</td>
</tr>
Expand Down Expand Up @@ -188,7 +188,7 @@ exports[`Storyshots Resource/MetadataDisplay With Extra Rows 1`] = `
<span
class="MuiTypography-root makeStyles-valueLabel MuiTypography-body1"
>
6/2/2021, 12:00:00 AM UTC
2021-06-02T00:00:00.000Z
</span>
</td>
</tr>
Expand Down Expand Up @@ -372,7 +372,7 @@ exports[`Storyshots Resource/MetadataDisplay With Owner References 1`] = `
<span
class="MuiTypography-root makeStyles-valueLabel MuiTypography-body1"
>
6/2/2021, 12:00:00 AM UTC
2021-06-02T00:00:00.000Z
</span>
</td>
</tr>
Expand Down
10 changes: 5 additions & 5 deletions frontend/src/components/common/Resource/__snapshots__/ResourceTable.stories.storyshot
View file
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ exports[`Storyshots ResourceTable Name Search 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="12/15/2021, 2:57:13 PM UTC"
title="2021-12-15T14:57:13.000Z"
>
3mo
<span />
Expand Down Expand Up @@ -220,7 +220,7 @@ exports[`Storyshots ResourceTable No Filter 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="12/15/2021, 2:57:13 PM UTC"
title="2021-12-15T14:57:13.000Z"
>
3mo
<span />
Expand Down Expand Up @@ -251,7 +251,7 @@ exports[`Storyshots ResourceTable No Filter 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="12/15/2021, 2:57:13 PM UTC"
title="2021-12-15T14:57:13.000Z"
>
3mo
<span />
Expand Down Expand Up @@ -282,7 +282,7 @@ exports[`Storyshots ResourceTable No Filter 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="12/15/2021, 2:57:13 PM UTC"
title="2021-12-15T14:57:13.000Z"
>
3mo
<span />
Expand Down Expand Up @@ -313,7 +313,7 @@ exports[`Storyshots ResourceTable No Filter 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="12/15/2021, 2:57:13 PM UTC"
title="2021-12-15T14:57:13.000Z"
>
3mo
<span />
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/crd/__snapshots__/CustomResourceDetails.stories.storyshot
View file
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ exports[`Storyshots crd/CustomResourceDetails No Error 1`] = `
<span
class="MuiTypography-root makeStyles-valueLabel MuiTypography-body1"
>
12/15/2021, 2:57:13 PM UTC
2021-12-15T14:57:13.000Z
</span>
</td>
</tr>
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/cronjob/__snapshots__/CronJobDetails.stories.storyshot
View file
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ exports[`Storyshots CronJob/CronJobDetailsView Every Ast 1`] = `
<span
class="MuiTypography-root makeStyles-valueLabel MuiTypography-body1"
>
1/1/2022, 12:00:00 AM UTC
2022-01-01T00:00:00.000Z
</span>
</td>
</tr>
Expand Down Expand Up @@ -476,7 +476,7 @@ exports[`Storyshots CronJob/CronJobDetailsView Every Minute 1`] = `
<span
class="MuiTypography-root makeStyles-valueLabel MuiTypography-body1"
>
1/1/2022, 12:00:00 AM UTC
2022-01-01T00:00:00.000Z
</span>
</td>
</tr>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/endpoints/__snapshots__/EndpointDetails.stories.storyshot
View file
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ exports[`Storyshots endpoints/EndpointsDetailsView Default 1`] = `
<span
class="MuiTypography-root makeStyles-valueLabel MuiTypography-body1"
>
4/25/2020, 12:00:00 AM UTC
2020-04-25T00:00:00.000Z
</span>
</td>
</tr>
Expand Down
10 changes: 5 additions & 5 deletions frontend/src/components/endpoints/__snapshots__/EndpointList.stories.storyshot
View file
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ exports[`Storyshots endpoints/EndpointsListView Items 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="1/1/2020, 12:00:00 AM UTC"
title="2020-01-01T00:00:00.000Z"
>
3mo
<span />
Expand Down Expand Up @@ -203,7 +203,7 @@ exports[`Storyshots endpoints/EndpointsListView Items 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="1/1/2020, 12:00:00 AM UTC"
title="2020-01-01T00:00:00.000Z"
>
3mo
<span />
Expand Down Expand Up @@ -240,7 +240,7 @@ exports[`Storyshots endpoints/EndpointsListView Items 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="1/1/2020, 12:00:00 AM UTC"
title="2020-01-01T00:00:00.000Z"
>
3mo
<span />
Expand Down Expand Up @@ -277,7 +277,7 @@ exports[`Storyshots endpoints/EndpointsListView Items 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="1/1/2020, 12:00:00 AM UTC"
title="2020-01-01T00:00:00.000Z"
>
3mo
<span />
Expand Down Expand Up @@ -314,7 +314,7 @@ exports[`Storyshots endpoints/EndpointsListView Items 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="1/1/2020, 12:00:00 AM UTC"
title="2020-01-01T00:00:00.000Z"
>
3mo
<span />
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/horizontalPodAutoscaler/__snapshots__/HPADetails.stories.storyshot
View file
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ exports[`Storyshots hpa/HpaDetailsView Default 1`] = `
<span
class="MuiTypography-root makeStyles-valueLabel MuiTypography-body1"
>
10/20/2022, 11:10:58 AM UTC
2022-10-20T11:10:58.000Z
</span>
</td>
</tr>
Expand Down
10 changes: 5 additions & 5 deletions frontend/src/components/horizontalPodAutoscaler/__snapshots__/HPAList.stories.storyshot
View file
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ exports[`Storyshots hpa/HpaListView Items 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="1/1/2020, 12:00:00 AM UTC"
title="2020-01-01T00:00:00.000Z"
>
3mo
<span />
Expand Down Expand Up @@ -337,7 +337,7 @@ exports[`Storyshots hpa/HpaListView Items 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="1/1/2020, 12:00:00 AM UTC"
title="2020-01-01T00:00:00.000Z"
>
3mo
<span />
Expand Down Expand Up @@ -407,7 +407,7 @@ exports[`Storyshots hpa/HpaListView Items 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="1/1/2020, 12:00:00 AM UTC"
title="2020-01-01T00:00:00.000Z"
>
3mo
<span />
Expand Down Expand Up @@ -477,7 +477,7 @@ exports[`Storyshots hpa/HpaListView Items 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="1/1/2020, 12:00:00 AM UTC"
title="2020-01-01T00:00:00.000Z"
>
3mo
<span />
Expand Down Expand Up @@ -547,7 +547,7 @@ exports[`Storyshots hpa/HpaListView Items 1`] = `
>
<p
class="MuiTypography-root makeStyles-noWrap MuiTypography-body1"
title="1/1/2020, 12:00:00 AM UTC"
title="2020-01-01T00:00:00.000Z"
>
3mo
<span />
Expand Down
Loading

0 comments on commit b441134

Please sign in to comment.