Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added selector to CircleImageView #25

Closed
wants to merge 7 commits into from
Closed

Conversation

sbelloz
Copy link

@sbelloz sbelloz commented Nov 12, 2014

No description provided.

@jenzz
Copy link

jenzz commented Dec 15, 2014

I like this PR 👍
Any chance we can get this merged and pushed to Maven Central @hdodenhof?

@sbelloz
Copy link
Author

sbelloz commented Dec 18, 2014

Thanks jenzz!

@jenzz
Copy link

jenzz commented Jan 6, 2015

@SimoneBellotti I just realized that after applying your changes any OnClickListener set on the view is no longer working.
Replacing return true; with return super.onTouchEvent(event); in onTouchEvent(MotionEvent event) should solve the issue. 😉

@sbelloz
Copy link
Author

sbelloz commented Jan 7, 2015

Yes, you're right! I've forgot it. Fixed

@jenzz jenzz mentioned this pull request Jan 7, 2015
This was referenced Jan 14, 2015
@hdodenhof
Copy link
Owner

Closing in favor of #35. Please have a look!

@hdodenhof hdodenhof closed this Jan 14, 2015
@rahat14 rahat14 mentioned this pull request Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants