Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pandas min version #618

Merged
merged 2 commits into from
May 20, 2021
Merged

Upgrade pandas min version #618

merged 2 commits into from
May 20, 2021

Conversation

rly
Copy link
Contributor

@rly rly commented May 19, 2021

Motivation

Fix #617

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #618 (60345b4) into dev (db51148) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #618   +/-   ##
=======================================
  Coverage   86.13%   86.13%           
=======================================
  Files          41       41           
  Lines        8237     8237           
  Branches     1775     1775           
=======================================
  Hits         7095     7095           
  Misses        811      811           
  Partials      331      331           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db51148...60345b4. Read the comment docs.

@rly
Copy link
Contributor Author

rly commented May 20, 2021

@ajtritt Do you think this merits a bugfix release (in both hdmf and pynwb)? See also conda-forge/pynwb-feedstock#37

@ajtritt
Copy link
Contributor

ajtritt commented May 20, 2021

@rly

Do you think this merits a bugfix release (in both hdmf and pynwb)?

If I understand things correctly, the latest PyNWB will not install. Is that right? If so, I then a bugfix release seems appropriate.

@rly
Copy link
Contributor Author

rly commented May 20, 2021

@rly

Do you think this merits a bugfix release (in both hdmf and pynwb)?

If I understand things correctly, the latest PyNWB will not install. Is that right? If so, I then a bugfix release seems appropriate.

I answered over Slack, but for completeness, the latest PyNWB will not run correctly if pandas==0.25 and numpy==1.20. And conda-forge tests fail, preventing a PyNWB release on conda, because their CI environment happens to have pandas==0.25 and numpy==1.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pandas <1.0.5 is not compatible with numpy 1.20
3 participants