Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert use of ColoredTestRunner (#89) #588

Merged
merged 3 commits into from
Apr 22, 2021
Merged

Revert use of ColoredTestRunner (#89) #588

merged 3 commits into from
Apr 22, 2021

Conversation

rly
Copy link
Contributor

@rly rly commented Apr 22, 2021

Motivation

Fix #578

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly
Copy link
Contributor Author

rly commented Apr 22, 2021

This returns the test suite functionality for CI, i.e., python test.py -v to the old, kinda ugly formatting. But all the errors and tracebacks are printed at the bottom of the output, which makes debugging a lot easier, especially now that we have around 1000 tests. The coloredtestrunner format was just not usable.

Eventually we can move our testing framework to pytest and stop using our custom unittest-based solution.

@rly rly marked this pull request as ready for review April 22, 2021 18:29
@rly rly requested a review from a team April 22, 2021 18:29
@rly rly merged commit 4a5e6b8 into dev Apr 22, 2021
@rly rly deleted the revert_coloredtests branch April 22, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove test formatting
2 participants