add start to Ontology table #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Todo: add ability to store annotations on records. This is needed for annotating CRID records. |
oruebel
reviewed
Oct 22, 2020
rly
requested changes
Nov 13, 2020
Co-authored-by: Ryan Ly <[email protected]>
rly
reviewed
Nov 13, 2020
Co-authored-by: Ryan Ly <[email protected]>
bendichter
reviewed
Nov 13, 2020
bendichter
reviewed
Nov 13, 2020
Comment on lines
+10
to
+12
| - name: key_name | ||
| dtype: text | ||
| doc: The user term that maps to one or more resources in the 'resources' table. |
There was a problem hiding this comment.
Am I reading this right that this is a complex data type of length 1? What is the advantage of that over just using a string dtype?
There was a problem hiding this comment.
The complex data type makes it easier to treat the dataset as a table.
bendichter
reviewed
Nov 13, 2020
Co-authored-by: Ryan Ly <[email protected]>
rly
reviewed
Nov 13, 2020
rly
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a compound data type table for storing ontology information
This is the schema addition needed for hdmf-dev/hdmf#339