Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History commit dev #208

Merged
merged 36 commits into from
Dec 3, 2022
Merged

History commit dev #208

merged 36 commits into from
Dec 3, 2022

Conversation

shewer
Copy link
Contributor

@shewer shewer commented Oct 20, 2022

add CommitHistoryReg
CommitRecordReg

iter() 是有問題

可否 加入 commit_history:iter()
能力有限 ,不會用c 做iter

for i,v in next , env.engine.context.commit_history:to_table() do
    yield( Candidate( v.type, seg.start, seg._end, v.text, 'history') )
end

shewer added 30 commits March 30, 2021 20:03
Signed-off-by: shewer <[email protected]>
Signed-off-by: shewer <[email protected]>
Signed-off-by: shewer <[email protected]>
Signed-off-by: shewer <[email protected]>
Signed-off-by: shewer <[email protected]>
Signed-off-by: shewer <[email protected]>
Signed-off-by: shewer <[email protected]>
* add  EngineReg select_schema()  env.engine:select( string schema_id ) .next

Signed-off-by: shewer <[email protected]>

* add engine:apply_schema( Schema &)   Schema( const string &)

Signed-off-by: shewer <[email protected]>
@hchunhui
Copy link
Owner

history 可以完全用 lua 实现,不需要再绑定 C++ 的接口了
#23 (comment)

@shewer
Copy link
Contributor Author

shewer commented Nov 5, 2022

history 可以完全用 lua 实现,不需要再绑定 C++ 的接口了 #23 (comment)

雖然不是強需求,但是可以調出,history
如: commit_text 是取不到的,但是 有將 commit_text push 到 history
https://github.com/rime/librime/blob/f7a456937802d063a781baf37c8698cd6d6b305e/src/rime/engine.cc#L229

librime 目前取不 到非lua_component commit_text 資料

@hchunhui hchunhui merged commit cf19d6a into hchunhui:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants