Recapture uncommitted work from stashes, worktrees, and untracked files - #22
Conversation
…mparison
Recaptured from stash@{0}, which was WIP on the pre-rebase branch
codex/hume-evi-clm-review-fixes. Everything else in that stash is already on
dev in a later form; this was the only content that never landed.
- overview.mdx regains the "Hosted one-click choices" section and the two
one-click support-matrix rows.
- render.mdx and railway.mdx regain the live deploy buttons, replacing the
"not published yet" <Warning> blocks that PRs #19-#21 put in their place.
- The Render button and deploy/render/blueprint-verification.json now name the
`dev` branch. The recaptured markup pointed at `tree/main`, but this fork's
origin has no main branch, so that button could never have resolved.
CAVEAT: this reverts a deliberate release gate. validate-deployment-templates.py
fails on this branch because every button is published while its verification
record is still null. That is the gate working, not a bug - the records must be
filled in from a real verified deploy before this reaches dev. Nothing here
fabricates that evidence: last_verified and verified_release are untouched.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Recaptured from the main worktree, where it was untracked and referenced by no branch. Records why framework/vectorstore tests fail rather than skip when the backing databases are absent, that make test-all stops at the first failing target so a red run there is truncated rather than conclusive, and how to bring the stack up. Measured on 2026-08-20 against dev at b157034; the note marks which rows are observed and which are derived from the compose file rather than a real run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…view tests Recaptured from an untracked pair of files in the bifrost-pr6333 worktree. PR maximhq#6333 itself is on dev as 2a64316; these review probes were never committed anywhere and existed only on disk. - The websocket auth context must not retain a harness-supplied session ID. - ResolveSessionIDFromRequest must parse the underscore header form Codex CLI sends, which fasthttp header-name normalization does not fold; benchmarks compare the lowercasing iteration against a direct Peek. - Oversized explicit x-bf-session-id handling. The last one is rewritten. As recaptured it asserted that an oversized x-bf-session-id was accepted verbatim, and it fails on dev: the merged form of maximhq#6333 caps every ingestion path at schemas.MaxSessionIDLength because session IDs become KV keys and exported trace attributes that nothing downstream bounds. The test now guards the behavior that actually shipped - the oversized value is dropped, and does not fall back to a harness header - with the original expectation recorded in a comment. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 32 minutes Limit details: You’ve used the included review currently available. Your 60 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
Comment |
fix: address PR #22 deployment and session review findings
Recapture uncommitted work from stashes, worktrees, and untracked files
fix: address PR #22 deployment and session review findings
Recapture uncommitted work from stashes, worktrees, and untracked files
fix: address PR #22 deployment and session review findings
Recapture uncommitted work from stashes, worktrees, and untracked files
fix: address PR #22 deployment and session review findings
Recapture uncommitted work from stashes, worktrees, and untracked files
fix: address PR #22 deployment and session review findings
Recaptures work that existed only in a stash, in untracked working-tree files, and in temporary worktrees — referenced by no branch and one
git cleanaway from being gone.Audit result
An audit of all 19 local branches and 4 worktrees found the raw
dev..branchcounts (up to 390 commits) to be almost entirely an artifact of the 2026-08-19/20 upstream rebase. Every commit that looked stranded turned out to already be ondev:d82b659f2devas10901184f; 21/23 files identical, the 2 docs files are richer ondev724052d70dev556373845dev-ahead0e689788ddevas2a64316c4So nothing needed cherry-picking. Everything below was uncommitted.
What this PR adds
docs(deploy)— restores the Render/Railway one-click buttons and the## Hosted one-click choicescomparison section fromstash@{0}. Buttons andblueprint-verification.jsonnow namedev: the recaptured markup pointed attree/main, but this fork's origin has nomainbranch, so that button could never have resolved.docs—vectorstore-test-infra.md(198 lines), untracked in the working tree. Records whyframework/vectorstoretests fail rather than skip without their databases, and thatmake test-allstops at the first failing target so a red run there is truncated rather than conclusive.test(transports)— PR maximhq#6333 session-resolution review probes, untracked in a temp worktree. Both packages pass.One of those tests was rewritten. As recaptured,
TestReviewOversizedExplicitSessionIsAcceptedasserted an oversizedx-bf-session-idpasses through verbatim — and it fails ondev, because the merged form of maximhq#6333 caps every ingestion path atschemas.MaxSessionIDLength(session IDs become KV keys and exported trace attributes that nothing downstream bounds). It now guards the behavior that shipped, with the original expectation recorded in a comment.validate-deployment-templates.pyfails on this branch:That is the gate from #19–#21 working as designed. Every button's
last_verified/verified_releaseis stillnull, and nothing here fabricates that evidence — the fields are untouched. The validator stops at the first error, so expect the same for the Render postgres and Railway buttons.Fill those records from a real verified deploy before merging, or drop the
docs(deploy)commit. The other two commits are independent of it.Not included
The 1.6.x working tree held a genuine v1.6.12 backport (
su-exec,BIFROST_CONFIG, privilege-drop tests, version bump) that cannot apply to adevbase without reverting the newer entrypoint. It is committed separately as651100815oncodex/render-railway-1.6.x.🤖 Generated with Claude Code
Summary by cubic
Recaptures uncommitted docs and tests, restores one‑click deploy buttons, and codifies session ID limits in new review tests. The previous review probe expected oversized
x-bf-session-idto pass; the new test asserts rejection to match shipped behavior and avoid unbounded keys and attributes.deploy/render/blueprint-verification.jsontodevandrender-sqlite.transports/bifrost-httpreview tests and benchmarks: parse underscore header form, ensure websocket context drops harness session, and enforceschemas.MaxSessionIDLength(oversized explicit IDs are dropped with no harness fallback).vectorstore-test-infra.mddescribing required services, known TLS Redis gaps, and thatmake test-allstops at the first failing target.validate-deployment-templates.pycurrently fails because verification fields are null. Verify the live templates and populatelast_verified/verified_release, or drop thedocs(deploy)commit.Written for commit c7aa3f6. Summary will update on new commits.