Don't unobserve and observe again (jupyterlab#39)

* Don't unobserve and observe again * Fix Test Prereleases
hbcarlos · Jan 29, 2023 · f838797 · f838797
1 parent 671fb6c
commit f838797
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -107,7 +107,7 @@ jobs:
           pip check
       - name: Run the tests
         run: |
-          pytest -vv || pytest -vv --lf
+          pytest -vv -W default || pytest -vv --lf
 
   make_sdist:
     name: Make SDist

diff --git a/jupyter_server_ydoc/ydoc.py b/jupyter_server_ydoc/ydoc.py
@@ -247,10 +247,6 @@ def on_document_change(self, event):
                 return
         except Exception:
             pass
-        # unobserve and observe again because the structure of the document may have changed
-        # e.g. a new cell added to a notebook
-        self.room.document.unobserve()
-        self.room.document.observe(self.on_document_change)
         if self.saving_document is not None and not self.saving_document.done():
             # the document is being saved, cancel that
             self.saving_document.cancel()