[API-424] Do not allow concurrent requests on SessionManager for the same group id #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should make sure that for the same group id, new create session requests should only be made if there is no session or the session is expired. To achieve this, a new Map that holds the group id to in-flight create session requests pairs is introduced. When an in-flight request is found for a group id, concurrent requests now wait for the initial request to complete (either normally or exceptionally) and then try again.
srknzl
reviewed
May 20, 2021
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
…same group id (hazelcast#904) * Do not allow concurrent requests on SessionManager for the same group id We should make sure that for the same group id, new create session requests should only be made if there is no session or the session is expired. To achieve this, a new Map that holds the group id to in-flight create session requests pairs is introduced. When an in-flight request is found for a group id, concurrent requests now wait for the initial request to complete (either normally or exceptionally) and then try again. * check the error text in the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should make sure that for the same group id, new create session requests
should only be made if there is no session or the session is expired.
To achieve this, a new Map that holds the group id to in-flight
create session requests pairs is introduced. When an in-flight request
is found for a group id, concurrent requests now wait for the initial
request to complete (either normally or exceptionally) and then try
again.
Closes #898