Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change doTryNextCluster logic to make it the same. [API-1354] #1403

Merged
merged 7 commits into from
Oct 25, 2022

Conversation

harunalpak
Copy link
Contributor

Before changes, client try only maxTryCount.
After code changes, client will try (candidateClusters.length * maxTryCount). For each cluster we will try maxTryCount.

@harunalpak harunalpak added this to the 5.2.0 milestone Oct 24, 2022
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #1403 (612882b) into master (62a2183) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1403   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files         464      464           
  Lines       16387    16387           
  Branches     1333     1333           
=======================================
  Hits        15285    15285           
+ Misses        804      803    -1     
- Partials      298      299    +1     
Impacted Files Coverage Δ
src/ClusterFailoverService.ts 98.07% <100.00%> (ø)
src/proxy/MultiMapProxy.ts 98.46% <0.00%> (-0.52%) ⬇️
src/protocol/ErrorFactory.ts 65.41% <0.00%> (+0.75%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@srknzl srknzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@harunalpak harunalpak merged commit e1d228b into hazelcast:master Oct 25, 2022
harunalpak added a commit to harunalpak/hazelcast-nodejs-client that referenced this pull request Dec 8, 2022
…ast#1403)

* Make ReadResultSet iterable [API-1315]

* Make ReadResultSet iterable [API-1315]

* Changes made according to comments on PR.[API-1315]

* Change doTryNextCluster logic to make it the same. [API-1354]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants