Port nested compact serialization sample [API-1332] #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some warnings in eslint. Can you run |
Codecov Report
@@ Coverage Diff @@
## master #1350 +/- ##
==========================================
- Coverage 93.27% 93.27% -0.01%
==========================================
Files 463 463
Lines 16347 16347
Branches 1329 1329
==========================================
- Hits 15248 15247 -1
+ Misses 800 799 -1
- Partials 299 301 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
srknzl
reviewed
Aug 31, 2022
|
|
||
| await client.shutdown(); | ||
| } catch (err) { | ||
| console.error('Error occurred:', err); |
There was a problem hiding this comment.
can you add process.exit(1); here? We add it to avoid script running forever if client stays open. In Node.js, if there is a socket running in the background, the process does not end, unless you end it yourself.
srknzl
approved these changes
Aug 31, 2022
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
* port nested compact serialization sample * port nested compact serialization sample * fix some eslint warnings and add process.exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.