Fix invalid error message [API-1490] #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1349 +/- ##
==========================================
+ Coverage 93.27% 93.29% +0.01%
==========================================
Files 463 464 +1
Lines 16347 16380 +33
Branches 1329 1332 +3
==========================================
+ Hits 15248 15281 +33
+ Misses 800 799 -1
- Partials 299 300 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fatihozer0
changed the title
srknzl
reviewed
Aug 16, 2022
|
I know there are unnecessary imports and some quality problems but before fixing them tests are not working I dont know why. Can you check? |
srknzl
reviewed
Sep 13, 2022
test/integration/backward_compatible/serial/CloudDiscoveryTest.js
Outdated
Show resolved
Hide resolved
fatihozer0
commented
Sep 23, 2022
fatihozer0
commented
Oct 6, 2022
|
All the comments are done. I think we can approve |
srknzl
approved these changes
Oct 13, 2022
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
* fix invalid error message * fix invalid error message * add test for cloud discovery config * add unit test for invalid discovery token * add unit test for invalid discovery token * add CloudDiscoveryInvalidToken unit test * delete wrong test file * delete wrong test file and fix code quality problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.