Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientClusterService apply events only with version larger than local version #1163

Merged

Conversation

srknzl
Copy link
Member

@srknzl srknzl commented Jan 6, 2022

closes #1054

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #1163 (51802d1) into master (cd6240e) will decrease coverage by 0.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
- Coverage   92.53%   92.12%   -0.42%     
==========================================
  Files         438      438              
  Lines       14521    14521              
  Branches     1085     1085              
==========================================
- Hits        13437    13377      -60     
- Misses        795      850      +55     
- Partials      289      294       +5     
Impacted Files Coverage Δ
src/invocation/ClusterService.ts 94.01% <100.00%> (ø)
src/codec/ClientAuthenticationCustomCodec.ts 42.22% <0.00%> (-33.34%) ⬇️
src/network/ConnectionManager.ts 75.17% <0.00%> (-8.52%) ⬇️
src/util/Util.ts 87.26% <0.00%> (-1.28%) ⬇️
src/config/ConfigBuilder.ts 90.13% <0.00%> (-1.10%) ⬇️
src/invocation/InvocationService.ts 93.36% <0.00%> (-0.89%) ⬇️
src/core/HazelcastError.ts 74.79% <0.00%> (-0.82%) ⬇️
src/protocol/ErrorFactory.ts 63.90% <0.00%> (-0.76%) ⬇️
src/proxy/MultiMapProxy.ts 97.12% <0.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd6240e...51802d1. Read the comment docs.

@srknzl srknzl merged commit a0671a5 into hazelcast:master Jan 6, 2022
harunalpak pushed a commit to harunalpak/hazelcast-nodejs-client that referenced this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRACKING ISSUE] ClientClusterService apply events only with version larger than local version
3 participants