Improve security config validation [master] #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdumandag
approved these changes
Dec 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #1152 +/- ##
==========================================
- Coverage 92.49% 92.13% -0.37%
==========================================
Files 438 438
Lines 14519 14521 +2
Branches 1085 1085
==========================================
- Hits 13430 13379 -51
- Misses 800 849 +49
- Partials 289 293 +4
Continue to review full report at Codecov.
|
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
Initialize username and password with null to avoid them being `undefined`. With `undefined` value it still works due to `CodecUtil.encodeNullable` logic but it may be confusing. Also, if `token` is not provided in token credentials throw instead of ignoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialized username and password with null to avoid them being
undefined. Withundefinedvalue it still works due toCodecUtil.encodeNullablelogic but it may be confusing.If
tokenis not provided in token credentials we throw instead of ignoring.