complete if-else branch to fix pylint error

haytham918 · Nov 27, 2023 · 7abc01d · 7abc01d
1 parent bfa99b5
commit 7abc01d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/copying.md b/copying.md
@@ -151,6 +151,7 @@ _the openage authors_ are:
 | Md Ashhar                   | ashhar                      | mdashhar01 à gmail dawt com                       |
 | Fábio Barkoski              | fabiobarkoski               | fabiobarkoskii à gmail dawt com                   |
 | Astitva Kamble              | askastitva                  | astitvakamble5 à gmail dawt com                   |
+| Haoyang Bi                  | AyiStar                     | ayistar à outlook dawt com                        |
 
 If you're a first-time committer, add yourself to the above list. This is not
 just for legal reasons, but also to keep an overview of all those nicknames.

diff --git a/openage/convert/entity_object/conversion/aoc/genie_unit.py b/openage/convert/entity_object/conversion/aoc/genie_unit.py
@@ -479,6 +479,8 @@ def is_unique(self) -> bool:
             else:
                 # AoE1
                 return False
+        else:
+            raise ValueError(f"Unknown group type for {repr(self)}")
 
         enabling_research_id = head_unit_connection["enabling_research"].value
-Original file line number
+Diff line change
@@ Expand Up / @@ -479,6 +479,8 @@ def is_unique(self) -> bool: @@
                 else:
                     # AoE1
                     return False
+            else:
+                raise ValueError(f"Unknown group type for {repr(self)}")
             enabling_research_id = head_unit_connection["enabling_research"].value
@@ Expand Down @@