Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update output syntax #36

Merged
merged 2 commits into from
Dec 3, 2022
Merged

update output syntax #36

merged 2 commits into from
Dec 3, 2022

Conversation

nicgrayson
Copy link
Contributor

@nicgrayson
Copy link
Contributor Author

@haya14busa pinging to make sure you saw this.

@shogo82148 shogo82148 requested a review from haya14busa December 2, 2022 22:27
Copy link
Collaborator

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the warning of shellcheck?

entrypoint.sh Outdated
@@ -107,7 +107,7 @@ fi

if [ -z "${BUMP_LEVEL}" ]; then
echo "PR with labels for bump not found. Do nothing."
echo "::set-output name=skip::true"
echo "skip=true" >> $GITHUB_OUTPUT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "skip=true" >> $GITHUB_OUTPUT
echo "skip=true" >> "$GITHUB_OUTPUT"

entrypoint.sh Outdated
Comment on lines 146 to 147
echo "current_version=${CURRENT_VERSION}" >> $GITHUB_OUTPUT
echo "next_version=${NEXT_VERSION}" >> $GITHUB_OUTPUT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "current_version=${CURRENT_VERSION}" >> $GITHUB_OUTPUT
echo "next_version=${NEXT_VERSION}" >> $GITHUB_OUTPUT
echo "current_version=${CURRENT_VERSION}" >> "$GITHUB_OUTPUT"
echo "next_version=${NEXT_VERSION}" >> "$GITHUB_OUTPUT"

Copy link
Collaborator

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@shogo82148 shogo82148 merged commit e184f8e into haya14busa:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants