Total Value does not account for Quantity

[camden-bock]

First Check

• This is not a feature request
• I added a very descriptive title to this issue.
• I used the GitHub search to find a similar issue and didn't find it.
• I searched the documentation, with the integrated search.
• I already read the docs and didn't find an answer.

Homebox Version

0.9.1

What is the issue you are experiencing?

Total Value sums the values (unit purchase price), without accounting for the quantity. It should instead sum the product of the purchase price and the quantity.

I am not very familiar with go, but this is called from frontend/pages/home/statistics.ts which calls frontend/lib/api/classes/stats.ts. I'm guessing that this then goes to line 229 in backend/internal/data/repo/repo_group.go

In 236 of repo_group.go, there is the relevant part of the query:

(SELECT SUM(purchase_price) FROM items WHERE group_items = ? AND items.archived = false) AS total_item_price,

I'm not sure if this is as simple as the following???

(SELECT SUM(purchase_price*quantity) FROM items WHERE group_items = ? AND items.archived = false) AS total_item_price,

How can the maintainer reproduce the issue?

Compare 'total value' to the sum of the BOM 'total price' column.

Deployment

Docker (Linux)

Deployment Details

No response

[Allram]

Also experiencing this.
I see that @cRaZy92 has fixed this in his own fork with commit: cRaZy92@c6bc12a

Is it possible to get this into this repo as well? :)

[cRaZy92]

Yea, it was very easy fix, I can create a pull request if that helps.

[hay-kot]

Yea, it was very easy fix, I can create a pull request if that helps.

Yes, please do!

[cRaZy92]

Never mind, since I already have a fork with many changes I can't do another one. Sorry, I thought that I could just make PR but I can't.

[Allram]

I can make one a bit later today based on your solution @cRaZy92.