Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maitake-sync]: Provide "is_closed" methods for WaitCell/WaitMap/WaitQueue #480

Merged
merged 3 commits into from
Jul 18, 2024
Merged

[maitake-sync]: Provide "is_closed" methods for WaitCell/WaitMap/WaitQueue #480

merged 3 commits into from
Jul 18, 2024

Conversation

jamesmunns
Copy link
Collaborator

Thank you Eliza!

hawkw
hawkw approved these changes Jul 18, 2024
View reviewed changes
Copy link
Owner

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one very tiny nitpick (adding must_use attributes); i'm going to apply the changes now and merge this. thank you!

maitake-sync/src/wait_cell.rs Show resolved Hide resolved
maitake-sync/src/wait_map.rs Show resolved Hide resolved
maitake-sync/src/wait_queue.rs Show resolved Hide resolved
@hawkw hawkw enabled auto-merge (squash) July 18, 2024 18:00
@hawkw hawkw merged commit c67c62f into main Jul 18, 2024
17 checks passed
@hawkw hawkw deleted the james/is-you-closed branch July 18, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesmunns @hawkw