-
-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(maitake-sync): rename
EnqueueWait
to Subscribe
`maitake-sync`'s `waitmap::Wait' future has an `enqueue` method that does the same thing as the `subscribe` methods on `WaitCell` and `WaitQueue`...but has a different name. I think this might be due to `enqueue` being added earlier or something, or maybe we just weren't paying attention. Regardless, I figured it was nicer to use the same name for the method that does the same thing on these different types. This commit renames the `waitmap::Wait::enqueue` method to `subscribe`, and the future it returns from `EnqueueWait` to `Subscribe`, analogously to `WaitQueue` and `WaitCell`. I've left a deprecated type alias and a deprecated function alias in place, so this isn't a breaking change: users who reference `Wait::enqueue` or `EnqueueWait` will still be able to compile their code, but they'll get a warning. cc @jamesmunns, since I believe you added this API?
- Loading branch information
Showing
2 changed files
with
26 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters