Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.1.0 (compilable, browser-ready, server-ready) #5

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

AbdoulSy
Copy link

@AbdoulSy AbdoulSy commented Aug 6, 2017

Hi Guys, Loved this VR demo, It almost is a part of one of my side projects, so I've been working on it for a couple of days after work,
to prevent having to hookup the vr setup to test at each line change I thought I would try to simplify my life by making this demo somehow work on a browser, and reload the code and reload the code on file change, and I'm in the process of trying to make the code more performant with low power devices, by first concatenating and compressing the code, making the code more modulable by using babel and a transpiler to write code in es6 with imports statements, and adding tests to stabilise all this.

I'm truly impressed by the maths skills though and would like to compliment on this.

So far this is where I've got, I thought you might hit the same issues in the future. 🥇

@AbdoulSy
Copy link
Author

AbdoulSy commented Aug 7, 2017

For some reason, it appears that on Android Phones (Galaxy S8) the application fails to load.
I'll implement a hotfix in the next few hours and will integrate it in this Pull Request.

@hawksley
Copy link
Owner

hawksley commented Aug 8, 2017

hmm.... So, I'm not sure this is bundled correctly. I had to separately npm install at least these packages to get npm start to compile happily:
three
webvr-polyfill
babel-cli
babel-preset-es2017
webpack

Then, when I go to localhost:9000 (which is definitely where it wants to automatically host for me, not localhost:8080) I see a black screen with the following console error:
Uncaught ReferenceError: InstallWebVRSpecShim is not defined
at Object.global.document (index.bundle.js:56129)
at webpack_require (index.bundle.js:20)
at Object. (index.bundle.js:50241)
at webpack_require (index.bundle.js:20)
at module.exports.ctor.super_ (index.bundle.js:63)
at index.bundle.js:66

I am using node v6.11.2 on Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants