Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(push): fix payload content-available crash #315

Closed
wants to merge 1 commit into from

Conversation

sithwarrior
Copy link

Changes notificationMessage from NSDictionary to NSMutableDictionary and the content-availble hander changes userinfo to a mutableCopy

Description

same as above

Related Issue

fixes #314

Motivation and Context

This fixes the app crashing at

[(NSMutableDictionary *) self.notificationMessage removeObjectForKey:@"applicationState"];

How Has This Been Tested?

receive a push payload with content-available:1

Screenshots (if appropriate):

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

@erisu erisu added this to the 5.0.1 milestone Nov 28, 2024
@erisu erisu added the ios Related to the iOS platform label Nov 28, 2024
@erisu erisu closed this in #317 Dec 2, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ios Related to the iOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes when activating Push Notification, after upgrading to v5 iOS
2 participants