fix(android): getCircleBitmap not displaying image #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set the
xfermode
after the circle is drawn so that the source bitmap is clipped correctly inside the circle.Previously, the
xfermode
was applied during the creation of the paint object, which caused a timing issue. As a result, the image was not clipped inside the circle properly, making it appear as though there was no image.Related Issue
Resolves #199
Motivation and Context
Fix the issue where
getCircleBitmap
was not displaying the image correctly.How Has This Been Tested?
Payload contained
image
pointing to a square image on web (square so I can confirm the circle effect)image-type
set tocircle
I also tried without setting the
image-type
to confirm default behavior.Screenshots (if appropriate):
Types of changes
Checklist: