Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haven 4.2 - conversion fixes #81

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

Tay8NWWFKpz9JT4NXU0w
Copy link
Contributor

there were several issues with the transaction construction and validation, which are fixed with this PR:

the wallet software was still trying to request XHV collateral with 0 amount, even though it was not needed
the output collection from pool 2 was not working properly when the block at the cut-off height did not have a particular asset outputs, like XUSD
in the validation, masks were required even for transfers
the "reverse" engineering of the net amount in color C used for conversion was not completely correct

@kleinroy kleinroy merged commit d6f17fc into haven-protocol-org:develop Sep 24, 2024
2 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants